Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

phoracek at redhat.com phoracek at redhat.com
Wed Dec 9 14:46:19 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50100/2/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File vdsm_hooks/ovs/ovs_before_network_setup_ip.py:

Line 167:                 # set networks IP configuration if any
Line 168:                 if ip_config.ipv4 or ip_config.ipv6:
Line 169:                     ip_config_to_set[ip_config.top_dev] = ip_config
Line 170: 
Line 171:     for bond, attrs in six.iteritems(bonds):
> There is a bit of duplicate code in it.
in case all bonds are new, we would iterate them twice, right? i would combine it and use nics_to_drop_ip_from here.
Line 172:         # drop initial IP config of bonds' slaves
Line 173:         if 'remove' not in attrs:
Line 174:             if bond in init_bonds:  # if bond was edited
Line 175:                 for nic in (set(attrs.get('nics')) -


-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list