Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

phoracek at redhat.com phoracek at redhat.com
Wed Dec 9 14:37:33 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50100/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-12-08 14:33:36 +0100
Line 6: 
Line 7: hooks: ovs: drop initial bonds' slaves IP config
Line 8: 
Line 9: Remove IP configuration of nics attached to Vdsm controlled bonds.
> I don't understand what was the bug (or caveat) and why is this addition ne
When i was implementing ovs ip configurator, i noticed, that ifcfg drops network nic's ip but keeps ip configuration of nics attached to a bond. So i created that two tests to document the behaviour and implement it correctly. Now when we decided to tag this behaviour as a bug and changed the test (https://gerrit.ovirt.org/#/c/49539/), i have to fix it here.
Line 10: 
Line 11: Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532


-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list