Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

alitke at redhat.com alitke at redhat.com
Thu Dec 3 20:34:14 UTC 2015


Adam Litke has posted comments on this change.

Change subject: getAllImages: Use manifest attributes when constructing glob pattern
......................................................................


Patch Set 1:

The test you are asking for doesn't make sense.  You're asking me to monkeypatch the environment to trick the glob code into finding an image somewhere and then we're going to change the code so that the mock becomes useless.  How about instead I just package a test for the new code that won't need any monkeypatching in the first place?

-- 
To view, visit https://gerrit.ovirt.org/49684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e69d3096a1b4c20dcee33e96c8a7bdd1b8dcaa9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list