Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

nsoffer at redhat.com nsoffer at redhat.com
Thu Dec 3 20:02:18 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: getAllImages: Use manifest attributes when constructing glob pattern
......................................................................


Patch Set 1: Code-Review-1

Looks good, but I would like a test in a previous patch before we touch this code. This should be easy to test since you can mock the repository patch/mountpoint, and test the code on a temporary directory.

-- 
To view, visit https://gerrit.ovirt.org/49684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e69d3096a1b4c20dcee33e96c8a7bdd1b8dcaa9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list