Change in vdsm[master]: vm: adding xpath property to device Base class

fromani at redhat.com fromani at redhat.com
Thu Dec 3 10:04:52 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: adding xpath property to device Base class
......................................................................


Patch Set 2:

Nothing is wrong, except the fact that this happens at runtime, making harder than necessary than work with this code.

But now _xpath is a private attribute, so it is OK, and is_attached_to already raises NotImplementedError correctly, so this patch does not make really sense at this moment.

Here's why I asked for a reshuffle, which didn't happen.
No big deal I guess, feel free to abandon.

-- 
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a7989cde44da0f756d48ae139fba47e524a40b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list