Change in vdsm[master]: vm: adding xpath property to device Base class

nsoffer at redhat.com nsoffer at redhat.com
Thu Dec 3 08:23:41 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: adding xpath property to device Base class
......................................................................


Patch Set 2:

Francesco, what is wrong with:

 >>> Device()._xpath
 Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
 AttributeError: Device instance has no attribute '_xpath'

Python alreay implemented that for us, we don't have to implement
anything to understand this issue.

This error is bad only for required attributes which we do not
initialize - this is separate issue.

-- 
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a7989cde44da0f756d48ae139fba47e524a40b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list