Change in vdsm[master]: net: Mapping bonding option value names to numerics
edwardh at redhat.com
edwardh at redhat.com
Tue Dec 1 16:05:23 UTC 2015
Edward Haas has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
......................................................................
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/49390/6/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 224: opt2change
> the name of the file is misleading, in this context it sounds more like a n
Done
Line 225: xrange
> please use six.range, as xrange would fail on Python3.
Done
Line 495: defaults
> misleading name
Done
https://gerrit.ovirt.org/#/c/49390/6/lib/vdsm/tool/dump_bonding_opts.py
File lib/vdsm/tool/dump_bonding_opts.py:
Line 1: 2014
> 2014-2015
Done
Line 54: json.dump(
> remove
Done
--
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list