Change in vdsm[master]: VolumeMetadata: metadata write utils

alitke at redhat.com alitke at redhat.com
Tue Dec 1 16:03:40 UTC 2015


Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: metadata write utils
......................................................................


Patch Set 20:

(2 comments)

https://gerrit.ovirt.org/#/c/41847/20/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 656: 
Line 657:     def getMetaOffset(self):
Line 658:         return self._md.getMetaOffset()
Line 659: 
Line 660:     def setMetadata(self, meta, metaId=None):
> This one is missing in FileVolume.
You're right!  The sdm_indirection_tests would have caught this if they were written :)
Line 661:         return self._md.setMetadata(meta, metaId)
Line 662: 
Line 663:     @classmethod
Line 664:     def newVolumeLease(cls, metaId, sdUUID, volUUID):


https://gerrit.ovirt.org/#/c/41847/20/vdsm/storage/fileVolume.py
File vdsm/storage/fileVolume.py:

Line 403
Line 404
Line 405
Line 406
Line 407
> This method is missing and is not in the volume class
Yep, moved setMetadata indirection method to the Volume class.


-- 
To view, visit https://gerrit.ovirt.org/41847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia245c589ea6bc2cf9ac1b2b59b9073d1b5fc9595
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list