Change in vdsm[master]: supervdsm: generalize udevTrigger method
nsoffer at redhat.com
nsoffer at redhat.com
Mon Aug 31 11:42:17 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/44767/12/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 289: Request device events from the kernel.
Line 290:
Line 291: Arguments:
Line 292:
Line 293: attr_matches A tuple of attribute-value tuples,
> I preferred the original "list" here, which is more human-readable. but let
No, we don't require a tuple and we should not have incorrect documentation.
Use iteratable instead of tuple/list.
Line 294: expanded like this:
Line 295:
Line 296: (('a', 'b'), ('c', 'd')) ~>
Line 297: --attr-match=a=b --attr-match=c=d
--
To view, visit https://gerrit.ovirt.org/44767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list