Change in vdsm[master]: supervdsm: generalize udevTrigger method

nsoffer at redhat.com nsoffer at redhat.com
Mon Aug 31 11:34:07 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: supervdsm: generalize udevTrigger method
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44767/12//COMMIT_MSG
Commit Message:

Line 11: devnum and busnum, and we should be somewhat able to do both these
Line 12: matches in a more generic function.
Line 13: 
Line 14: This patch refactors udevTrigger to include attr_matches and
Line 15: property_matches. When tuple of attribute-value tuples is sent,
When a tuple of -> when a iteratable of

We dot not care about the of type of property_matches and attr_matches, on ly about being able to iterate them.
Line 16: they're expanded to the correct udevadm command.
Line 17: 
Line 18: Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7


-- 
To view, visit https://gerrit.ovirt.org/44767
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list