Change in vdsm[master]: StorageDomainManifest: Move getRepoPath and other metadata g...

nsoffer at redhat.com nsoffer at redhat.com
Fri Aug 14 20:53:34 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: StorageDomainManifest: Move getRepoPath and other metadata getters
......................................................................


Patch Set 20: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/42267/20/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 318:     def getRepoPath(self):
Line 319:         # This is here to make sure no one tries to get a repo
Line 320:         # path from an ISO domain.
Line 321:         if self.getDomainClass() == ISO_DOMAIN:
Line 322:             raise se.ImagesNotSupportedError()
This seem to belong to ISOStorageDomain class, overriding the base class implementation, but lets not change this now.
Line 323: 
Line 324:         # Get the datacenter ID.  When using storage pools this will be the
Line 325:         # spUUID.  Else, it's just a UUID to establish a storage namespace.
Line 326:         return os.path.join(storage_repository, self.getPools()[0])


-- 
To view, visit https://gerrit.ovirt.org/42267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571437a10a53d5aa20c83438350476d03111a704
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list