Change in vdsm[master]: StorageDomainManifest: move extend and extendVolume

nsoffer at redhat.com nsoffer at redhat.com
Fri Aug 14 20:48:31 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: StorageDomainManifest: move extend and extendVolume
......................................................................


Patch Set 20: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42266/20/tests/sdm_indirection_tests.py
File tests/sdm_indirection_tests.py:

Line 144: 
Line 145: class FakeDomainMixin(object):
Line 146:     def __init__(self):
Line 147:         self.stat = None
Line 148:         self._manifest = self.manifestClass()
I think this is simple enough to do in FakeBlockStorageDomain and FakeFileStorageDomain, adding mixin to the party just make things more complicated then needed, for saving 2 lines of code in each class.

Without this, the code would be even shorter.

What do you think?
Line 149: 
Line 150: 
Line 151: class FakeBlockStorageDomain(blockSD.BlockStorageDomain, FakeDomainMixin):
Line 152:     manifestClass = FakeBlockDomainManifest


-- 
To view, visit https://gerrit.ovirt.org/42266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ad1769d7e4db6fc0883b37a67d071c278b96c8b
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list