Change in vdsm[master]: vm: graphics: fix console open after restore

fromani at redhat.com fromani at redhat.com
Fri Aug 14 12:56:51 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: graphics: fix console open after restore
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/44842/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1958:     def _correctSpiceConfiguration(self, srcDomXML):
Line 1959:         """
Line 1960:         TODO: documentation
Line 1961:         """
Line 1962:         outDomXML = srcDomXML
> Is it needed to create a new reference in this case? Couldn't you operate d
will streamline the flow
Line 1963:         for dev in self._devices[hwclass.GRAPHICS]:
Line 1964:             outDomXML = dev.updateXML(outDomXML)
Line 1965:         return outDomXML
Line 1966: 


https://gerrit.ovirt.org/#/c/44842/1/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 137:         if not utils.tobool(self.specParams.get('disableTicketing', False)):
Line 138:             attrs['passwd'] = '*****'
Line 139:             attrs['passwdValidTo'] = '1970-01-01T00:00:01'
Line 140: 
Line 141:     def updateXML(self, domXML):
> I dislike the name - it's very generic while the functionality is quite spe
Done
Line 142:         if self.device == 'spice':
Line 143:             domObj = etree.fromstring(domXML)
Line 144:             devices = domObj.findall('devices')
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/44842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9f11e2d87cc715c77d305c005c1cd7f502d506d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list