Change in vdsm[master]: vm: remove misleading XMl creation and hook call

fromani at redhat.com fromani at redhat.com
Fri Aug 14 12:40:16 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: remove misleading XMl creation and hook call
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/44843/4//COMMIT_MSG
Commit Message:

Line 7: vm: remove misleading XMl creation and hook call
Line 8: 
Line 9: When VDSM is asked to create a new VM, among the other things,
Line 10: it builds the domain XML according to the configuration sent
Line 11: by client (aka Engine) and run the before_vm_create hook.
before_vm_start
Line 12: 
Line 13: This is done also on the dehibernating (aka migration from file)
Line 14: path, for reasons unknown.
Line 15: 


Line 23: Additionally, in the dehibernation path we add a log for
Line 24: the XML which is actually about to be fed to libvirt.
Line 25: 
Line 26: CAUTION:
Line 27: Noteworthy side effect: the before_vm_create hook is
before_vm_start
Line 28: no longer called in the dehibernation path.
Line 29: Please note that the output of the hook was *discarded*
Line 30: before, so the only meaningful action the hook could have done
Line 31: is some obscure side effect outside the system.


-- 
To view, visit https://gerrit.ovirt.org/44843
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list