Change in vdsm[master]: unbreak InterfaceSampleTests.

danken at redhat.com danken at redhat.com
Wed Apr 29 13:26:24 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: unbreak InterfaceSampleTests.
......................................................................


unbreak InterfaceSampleTests.

testHostSampleReportsNewInterface and
testHostSampleHandlesDisappearingVlanInterfaces made simpler. The
compromise here is not testing the HostSample() public interface, which
is more correct, but harder to fake.

Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40346
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/samplingTests.py
1 file changed, 9 insertions(+), 15 deletions(-)

Approvals:
  Ido Barkan: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list