Change in vdsm[master]: unbreak InterfaceSampleTests.

danken at redhat.com danken at redhat.com
Wed Apr 29 13:26:20 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: unbreak InterfaceSampleTests.
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/40346/6/tests/samplingTests.py
File tests/samplingTests.py:

Line 158:         with dummy_if() as dummy_name:
Line 159:             interfaces_after = set(
Line 160:                 sampling._get_interfaces_and_samples().iterkeys())
Line 161:             interfaces_diff = interfaces_after - interfaces_before
Line 162:             self.assertEqual(interfaces_diff, {dummy_name})
> yay for set literals! :)
unrelated to the topic of the patch, but I won't spoil the farewell-to-2.6 party
Line 163: 
Line 164:     @ValidateRunningAsRoot
Line 165:     def testHostSampleHandlesDisappearingVlanInterfaces(self):
Line 166:         original_getLinks = ipwrapper.getLinks


-- 
To view, visit https://gerrit.ovirt.org/40346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list