Change in vdsm[master]: vmdevices: bootstrap video module and isolate it's functiona...
fromani at redhat.com
fromani at redhat.com
Fri Apr 24 12:26:11 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vmdevices: bootstrap video module and isolate it's functionality
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40138/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 340: self.log.info("migration took %d seconds to complete",
Line 341: (time.time() - startTime) + destCreationTime)
Line 342:
Line 343: def _perform_migration(self, duri, muri):
Line 344: if vmdevices.video.conf_has_spice(self._vm.conf) \
minor nit: please avoid '\', better use parens.
Line 345: and self._vm.conf.get('clientIp'):
Line 346: SPICE_MIGRATION_HANDOVER_TIME = 120
Line 347: self._vm._reviveTicket(SPICE_MIGRATION_HANDOVER_TIME)
Line 348:
https://gerrit.ovirt.org/#/c/40138/2/vdsm/virt/vmdevices/__init__.py
File vdsm/virt/vmdevices/__init__.py:
Line 27: from . import storage
Line 28: from . import video
Line 29:
Line 30: # Silence pyflakes
Line 31: core, graphics, hostdevice, hwclass, network, sound, storage, video
same, we need to find a better solution. Not necessarily you, surely not in this patch.
https://gerrit.ovirt.org/#/c/40138/2/vdsm/virt/vmdevices/video.py
File vdsm/virt/vmdevices/video.py:
Line 35: for dev in conf.get('devices', [])
Line 36: if dev['type'] == hwclass.GRAPHICS))
Line 37:
Line 38:
Line 39: def mapping_from_legacy_conf(conf, arch):
same as per sound device, I think 'dev_spec_list_from_legacy_conf' will be clearer.
Line 40: """
Line 41: Normalize video device provided by conf.
Line 42: """
Line 43: vcards = []
--
To view, visit https://gerrit.ovirt.org/40138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51a24965015b1eff63e5cfedd63fb4cda968a89
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list