Change in vdsm[master]: stomp: server side subscriptions

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Apr 22 13:40:44 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: server side subscriptions
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/38451/13/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 147:             # ignore
Line 148:             return
Line 149: 
Line 150:         del self._sub_ids[sub_id]
Line 151:         subs = self._sub_dests[subscription.destination]
> we use defaultdict
I was wrong will check keyError.
Line 152:         if len(subs) == 1:
Line 153:             del self._sub_dests[subscription.destination]
Line 154:         else:
Line 155:             if subscription in subs:


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list