Change in vdsm[master]: v2v: Job related actions
fromani at redhat.com
fromani at redhat.com
Fri Apr 10 09:59:25 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: v2v: Job related actions
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39361/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 263:
Line 264: def _get_job(job_id):
Line 265: with _lock:
Line 266: if job_id not in _jobs:
Line 267: raise NoSuchJob()
> I asked to add the job id to all errors, so we can follow a job in the log
Yes, the benefits seems to outweight the (supposed) redundancy, so let's just add job_id everywhere
Line 268: return _jobs[job_id]
Line 269:
Line 270:
Line 271: def _remove_job(job_id):
--
To view, visit https://gerrit.ovirt.org/39361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list