Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

fromani at redhat.com fromani at redhat.com
Fri Apr 10 09:52:02 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 20:

(2 comments)

looks good, should be fine once Nir's comments are addressed. A couple of minor glitches spotted.

https://gerrit.ovirt.org/#/c/37509/20/client/vdsClient.py
File client/vdsClient.py:

Line 1917: 
Line 1918:         return status['status']['code'], status['status']['message']
Line 1919: 
Line 1920:     def convertExternalVm(self, args):
Line 1921:         validateArgTypes(args, [str, str, str, str, {}, str])
I think you need 'dict' here instead of '{}'. Please check.
Line 1922:         if len(args) != 5:
Line 1923:             raise ValueError('Wrong number of arguments')
Line 1924:         uri, username, password, vmProperties, jobId = args
Line 1925:         password = getAuthFromArgs(args, password)


https://gerrit.ovirt.org/#/c/37509/20/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3806: #
Line 3807: # @vmProperties: information of the VM such as name, id etc
Line 3808: #
Line 3809: # @jobId:        Assign a UUID to this operation which can be used
Line 3810: #                to identify it in @VmStats
You mean HostStats, right?
Line 3811: #
Line 3812: # Since: 4.17.0
Line 3813: ##
Line 3814: {'command': {'class': 'Host', 'name': 'convertExternalVm'},


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list