Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
asegurap at redhat.com
asegurap at redhat.com
Mon Sep 29 10:14:11 UTC 2014
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:
Line 81:
Line 82: with open(BONDING_DEFAULTS, 'w') as defaults:
Line 83: defaults.write(json.dumps(_get_default_bonding_options(),
Line 84: sort_keys=True, indent=4,
Line 85: separators=(',', ': ')) + '\n')
> If the extra options are supported I'll switch to json.dump
Thanks
Line 86:
Line 87: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list