Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

danken at redhat.com danken at redhat.com
Mon Sep 29 10:11:55 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 408:     Return default options per mode, in a dictionary of dictionaries. All keys
Line 409:     are numeric modes stored as strings for coherence with 'mode' option value.
Line 410:     """
Line 411:     with open(BONDING_DEFAULTS) as defaults:
Line 412:         return json.loads(defaults.read())
> I wonder if we should catch for ENOENT and then run vdsm-tool to create the
vdsm-tool needs to be run as root. we could add it to sudoers, but one of the benefits of this patch's approach is that no sudo backdoors are needed.

I'd rather collect this  data on service startup, and assume that it's there during runtime.
Line 413: 
Line 414: 
Line 415: @memoized
Line 416: def _getDefaultBondingOptions(mode=None):


-- 
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list