Change in vdsm[master]: netinfo: Stop NetworkManager from ifup'ing our reference bond
danken at redhat.com
danken at redhat.com
Wed Sep 24 12:06:16 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Stop NetworkManager from ifup'ing our reference bond
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/33227/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 76: 'ad_num_ports', 'ad_actor_key', 'ad_partner_key', 'ad_partner_mac'
Line 77: ))
Line 78: _IFCFG_ZERO_SUFFIXED = frozenset(
Line 79: ('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
Line 80: _NM_CLI_BINARY = CommandPath('nmcli', constants.EXT_NMCLI)
> /usr/bin/tee I regard as omnipresent so no abstraction is needed. Not so in
The removal of tee is an unnecessary part of this patch. It only makes it a bit more complex. Please keep it.
Line 81:
Line 82: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 83: DEFAULT_MTU = '1500'
Line 84:
Line 454: with _avoidNetworkManager(bondName):
Line 455: rc, _, _ = execCmd([teeCmd, BONDING_MASTERS], data='+' + bondName,
Line 456: sudo=True)
Line 457: if rc:
Line 458: raise RuntimeError('Creating a reference bond failed.')
I don't think that dropping "err" is a good idea. It is certainly unrelated to this patch.
Line 459:
Line 460: opts = {}
Line 461: try:
Line 462: defaultMode = bondOpts(bondName, keys=['mode'])['mode']
--
To view, visit http://gerrit.ovirt.org/33227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff14c4791355f05890805a8d6b5208e7adb0ef7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list