Change in vdsm[master]: netinfo: Stop NetworkManager from ifup'ing our reference bond

osvoboda at redhat.com osvoboda at redhat.com
Wed Sep 24 08:03:01 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: Stop NetworkManager from ifup'ing our reference bond
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/33227/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 76:     'ad_num_ports', 'ad_actor_key', 'ad_partner_key', 'ad_partner_mac'
Line 77: ))
Line 78: _IFCFG_ZERO_SUFFIXED = frozenset(
Line 79:     ('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
Line 80: _NM_CLI_BINARY = CommandPath('nmcli', constants.EXT_NMCLI)
/usr/bin/tee I regard as omnipresent so no abstraction is needed. Not so in the case of nmcli.
Line 81: 
Line 82: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 83: DEFAULT_MTU = '1500'
Line 84: 


Line 427:     if has_nm:
Line 428:         nmcli = _NM_CLI_BINARY.cmd
Line 429:         ifcfgPath = NET_CONF_PREF + interface
Line 430:         execCmd([constants.EXT_TEE, ifcfgPath],
Line 431:                 data=('DEVICE=%s\nNM_CONTROLLED=no\n' % interface), sudo=True)
\n was missing last time, resulting in the line being unparsed.

The superfluous parentheses are gone in my local update.
Line 432: 
Line 433:         rc, _, _ = execCmd([nmcli, 'conn', 'load', ifcfgPath], sudo=True)
Line 434:         if rc:
Line 435:             raise RuntimeError('Failed to unmanage %s.' % interface)


-- 
To view, visit http://gerrit.ovirt.org/33227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff14c4791355f05890805a8d6b5208e7adb0ef7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list