Change in vdsm[master]: Configure iSCSI iface.net_ifacename

apahim at redhat.com apahim at redhat.com
Fri Sep 19 00:55:22 UTC 2014


Amador Pahim has posted comments on this change.

Change subject: Configure iSCSI iface.net_ifacename
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 149: 
Line 150: def _resolveIscsiIface(ifaceName, initiatorName, netIfacename):
Line 151:     if not ifaceName:
Line 152:         iface = iscsi.IscsiInterface('default')
Line 153:         iface.netIfacename = netIfacename
> Sorry, I do not understand your answer; nor why you set the iface.netIfacen
Set iface.netIfacename is not needed in fact. Removing.
Line 154:         return iface
Line 155: 
Line 156:     for iface in iscsi.iterateIscsiInterfaces():
Line 157:         if iface.name == ifaceName:


Line 156:     for iface in iscsi.iterateIscsiInterfaces():
Line 157:         if iface.name == ifaceName:
Line 158:             iface.netIfacename = netIfacename
Line 159:             if netIfacename:
Line 160:                 iface.update()
> But why change and existing interface? Isn't it dangerous, in case it is al
I was wondering in solve a case where user could change a non-bridged network to a bridged, or the opposite. Currently, once created, iface will never be removed, recreated or updated, even if the net_ifacename changes. But seems like this is subject for another bz/discussion. Implementing this here may be dangerous indeed.
Line 161:             return iface
Line 162: 
Line 163:     iface = iscsi.IscsiInterface(ifaceName, initiatorName=initiatorName,
Line 164:                                  netIfacename=netIfacename)


-- 
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list