Change in vdsm[master]: Configure iSCSI iface.net_ifacename

danken at redhat.com danken at redhat.com
Thu Sep 18 21:50:21 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Configure iSCSI iface.net_ifacename
......................................................................


Patch Set 13:

(3 comments)

http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 149: 
Line 150: def _resolveIscsiIface(ifaceName, initiatorName, netIfacename):
Line 151:     if not ifaceName:
Line 152:         iface = iscsi.IscsiInterface('default')
Line 153:         iface.netIfacename = netIfacename
> "default" means not using iscsi bond feature. So, no netIfacename will arri
Sorry, I do not understand your answer; nor why you set the iface.netIfacename here.
Line 154:         return iface
Line 155: 
Line 156:     for iface in iscsi.iterateIscsiInterfaces():
Line 157:         if iface.name == ifaceName:


Line 156:     for iface in iscsi.iterateIscsiInterfaces():
Line 157:         if iface.name == ifaceName:
Line 158:             iface.netIfacename = netIfacename
Line 159:             if netIfacename:
Line 160:                 iface.update()
> I'm trying here to existing iface with modified netIfacename will be update
But why change and existing interface? Isn't it dangerous, in case it is already used?
Line 161:             return iface
Line 162: 
Line 163:     iface = iscsi.IscsiInterface(ifaceName, initiatorName=initiatorName,
Line 164:                                  netIfacename=netIfacename)


http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 152:         username = None
Line 153:     if password in ["<NULL>", "(null)"]:
Line 154:         password = None
Line 155: 
Line 156:     if netdev in ["<NULL>", "(null)"]:
> Ok, keeping for now.
Fine. But the general rule should be - if and object does not need to change, it should be immutable.

Since we no longer support el5, this code can be simplified; in any case, its repetitiveness and need of a comment suggest that a helper function is in place.
Line 157:         netdev = None
Line 158: 
Line 159:     iface = IscsiInterface(iface, netIfacename=netdev)
Line 160:     portal = IscsiPortal(ip, port)


-- 
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list