Change in vdsm[master]: Rounding up swap usage

ybronhei at redhat.com ybronhei at redhat.com
Mon Sep 15 09:47:09 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Rounding up swap usage
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32911/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Rounding up swap usage
Line 8: 
Line 9: While dividing swap memory in 1024 we cut the floating number and round
Line 10: it down. This patch rounds the value up.
> 1. Avoid the "math" module in Vdsm. Float calculus is inaccurate.
that's what the main user of vdsm asks (the engine, which checks the threshold in MB and prefer to loose few KB than failing operation or report warnings). if you think that's wrong please reply in the bug
Line 11: 
Line 12: Change-Id: I7eb33f0f003f7442efb103f43bbc60c5faa6a439
Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135909


-- 
To view, visit http://gerrit.ovirt.org/32911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7eb33f0f003f7442efb103f43bbc60c5faa6a439
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list