Change in vdsm[master]: Rounding up swap usage

danken at redhat.com danken at redhat.com
Sun Sep 14 20:17:56 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Rounding up swap usage
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32911/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Rounding up swap usage
Line 8: 
Line 9: While dividing swap memory in 1024 we cut the floating number and round
Line 10: it down. This patch rounds the value up.
1. Avoid the "math" module in Vdsm. Float calculus is inaccurate.

2. To round a/b up, use (a+b-1)/b

3. In this case, rounding down is more prudent. If we don't have full MiB of swap, why claim that we do?
Line 11: 
Line 12: Change-Id: I7eb33f0f003f7442efb103f43bbc60c5faa6a439
Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135909


-- 
To view, visit http://gerrit.ovirt.org/32911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7eb33f0f003f7442efb103f43bbc60c5faa6a439
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list