Change in vdsm[master]: net: getLinks: avoid redundant list creation

danken at redhat.com danken at redhat.com
Fri Sep 12 10:37:43 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: getLinks: avoid redundant list creation
......................................................................


net: getLinks: avoid redundant list creation

Returning an iterator is cheaper than creating a possibly-long
throwaway list.

Change-Id: I566b145d76dee6724a4d84c45d9cb2098fae9df7
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32844
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
---
M lib/vdsm/ipwrapper.py
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I566b145d76dee6724a4d84c45d9cb2098fae9df7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list