Change in vdsm[master]: net: getLinks: avoid redundant list creation

danken at redhat.com danken at redhat.com
Fri Sep 12 10:37:41 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: net: getLinks: avoid redundant list creation
......................................................................


Patch Set 1: Verified+1 Code-Review+2

Verified by running the unit and functional tests on el7.

 Ran 99 tests in 541.767s

The following failure is unrelated to this patch, but a bit worrying.

ERROR: testAlignedAppend (miscTests.DdWatchCopy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/vdsm/tests/miscTests.py", line 411, in testAlignedAppend
    "/dev/zero", path, None, misc.MEGA, os.stat(path).st_size)
  File "/root/vdsm/vdsm/storage/misc.py", line 343, in ddWatchCopy
    deathSignal=signal.SIGKILL)
  File "/root/vdsm/lib/vdsm/utils.py", line 597, in execCmd
    deathSignal=deathSignal, childUmask=childUmask)
  File "/usr/lib64/python2.7/site-packages/cpopen/__init__.py", line 51, in __init__
    stderr=PIPE)
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/site-packages/cpopen/__init__.py", line 81, in _execute_child_v275
    self._childUmask)
OSError: [Errno 0] Error
-------------------- >> begin captured logging << --------------------
Storage.Misc.excCmd: DEBUG: /usr/bin/nice -n 19 /usr/bin/ionice -c 3 /usr/bin/dd if=/dev/zero of=/var/tmp/tmpE69tcu bs=1048576 seek=1 skip=1 conv=notrunc count=1 oflag=direct (cwd None)

-- 
To view, visit http://gerrit.ovirt.org/32844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I566b145d76dee6724a4d84c45d9cb2098fae9df7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list