Change in vdsm[master]: tool: use natural numbers for configuration versioning.

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 9 22:39:05 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tool: use natural numbers for configuration versioning.
......................................................................


Patch Set 2: Code-Review-1

According to http://gerrit.ovirt.org/#/c/32713/1/tests/toolTests_qemu_ssl.conf

You are using the configuration version as if it is 
the vdsm version:

    ## beginning of configuration section by vdsm-CONF_VERSION

You cannot use this text *and* use a number which is not vdsm version.

Writing "by vdsm-x.y.z" and expecting people to understand that "x.y.z"
is not vdsm's version is absurd :-)

I think we want something like this:

    ## beginning of vdsm configuration section version=5

Before posting this, do some hallway testing to ensure that
the this header is clear.

[1] http://en.wikipedia.org/wiki/Usability_testing#Hallway_testing

-- 
To view, visit http://gerrit.ovirt.org/32708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f50e30fe03acb101aed4b1a7aece196a77b4c6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list