Change in vdsm[master]: tool: use natural numbers for configuration versioning.

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 9 22:18:19 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tool: use natural numbers for configuration versioning.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32708/2/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 301: 
Line 302:     # version != PACKAGE_VERSION since we do not want to update configuration
Line 303:     # on every update. see 'configuration versioning:' at Configfile.py for
Line 304:     # details.
Line 305:     CONF_VERSION = '1'
Since we already used 4 (4.17.0), and we like to move to single number for the configuration version, we should use 5.
Line 306: 
Line 307:     PKI_DIR = os.path.join(constants.SYSCONF_PATH, 'pki/vdsm')
Line 308:     LS_CERT_DIR = os.path.join(PKI_DIR, 'libvirt-spice')
Line 309: 


-- 
To view, visit http://gerrit.ovirt.org/32708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f50e30fe03acb101aed4b1a7aece196a77b4c6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list