Change in vdsm[master]: hsm: validate storage pool in prepareImage

danken at redhat.com danken at redhat.com
Sun Sep 7 08:20:28 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hsm: validate storage pool in prepareImage
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32502/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-09-04 17:09:03 +0000
Line 6: 
Line 7: hsm: validate storage pool in prepareImage
Line 8: 
Line 9: If the storage pool is specified (non-blank) we should validate that
Could you explain why we should? If we don't use an arg, we can deprecate it, and have a leaner quicker function.
Line 10: we're connected.
Line 11: 
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130995
Line 13: Change-Id: Ia85c2b2acedf7bdbadd930596987cc4828e24ddd


-- 
To view, visit http://gerrit.ovirt.org/32502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia85c2b2acedf7bdbadd930596987cc4828e24ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list