Change in vdsm[master]: hsm: validate storage pool in prepareImage

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 4 17:38:53 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: hsm: validate storage pool in prepareImage
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32502/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3230: 
Line 3231:         # If the pool is not blank we should make sure that we are connected
Line 3232:         # to the pool.
Line 3233:         if spUUID != sd.BLANK_UUID:
Line 3234:             self.getPool(spUUID)
Shouldn't we do this before taking the lock?
Line 3235: 
Line 3236:         imgVolumesInfo = []
Line 3237:         dom = sdCache.produce(sdUUID)
Line 3238:         allVols = dom.getAllVolumes()


-- 
To view, visit http://gerrit.ovirt.org/32502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia85c2b2acedf7bdbadd930596987cc4828e24ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list