Change in vdsm[master]: Introduction for caching the parsed domain XML

fromani at redhat.com fromani at redhat.com
Thu Oct 2 06:53:35 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Introduction for caching the parsed domain XML
......................................................................


Patch Set 25:

(1 comment)

http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4489:         return pid
Line 4490: 
Line 4491:     def _updateDomainDescriptor(self):
Line 4492:         domainXML = self._dom.XMLDesc(0)
Line 4493:         self._lastXMLDesc = DomainDescriptor(domainXML)
> We can also do it in another patch - but this patch changes every line that
'domain' is nicer and shorter, and as you said saves developer time. Will change.

Should I also squash http://gerrit.ovirt.org/#/c/33672/1 in this? Only name are changed, non changes in functioning.
Line 4494: 
Line 4495:     def _ejectFloppy(self):
Line 4496:         if 'volatileFloppy' in self.conf:
Line 4497:             utils.rmFile(self.conf['floppy'])


-- 
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list