Change in vdsm[master]: virt: sampling: consolidate disk statistics

nsoffer at redhat.com nsoffer at redhat.com
Thu Oct 2 06:43:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: virt: sampling: consolidate disk statistics
......................................................................


Patch Set 4:

(1 comment)

Partial review

http://gerrit.ovirt.org/#/c/29953/4//COMMIT_MSG
Commit Message:

Line 16: and cheaper to read all the needed information in one go,
Line 17: saving one libvirt call without losing any information.
Line 18: 
Line 19: If the configuration is different, the old behaviour is
Line 20: preserved for the sake of backward compatibility.
Do we need this backward compatibility? I think this configuration is for us, so we can modify the behavior easily, not for users. This configuration is not documented right?

Lets drop the false backward compatibility and simplify the code.
Line 21: 
Line 22: Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c


-- 
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list