Change in vdsm[master]: dummy_nics: add hotplug=no so udev does not ifup them

asegurap at redhat.com asegurap at redhat.com
Wed Nov 12 14:47:14 UTC 2014


Antoni Segura Puimedon has uploaded a new change for review.

Change subject: dummy_nics: add hotplug=no so udev does not ifup them
......................................................................

dummy_nics: add hotplug=no so udev does not ifup them

In EL6 udev/initscripts execute ifup if an ifcfg file exists for the
just plugged device (which applies often for virtual devices). Due
to how troubling this functionality is they removed it from el7/F20+
but in el6 it can disrupt our configuring with parallel ifups,
overriding of bond slaves config, etc.

Change-Id: If07817d51ee8c71a1bcfe7d45f110b884fd516fd
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/35089/1

diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py
index 6c91455..4f7cc07 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -659,6 +659,8 @@
     def addNic(self, nic, **opts):
         """ Create ifcfg-* file with proper fields for NIC """
         conf = ''
+        if ipwrapper.Link._detectType(nic.name) == 'dummy':
+            opts['hotplug'] = 'no'
         if _hwaddr_required():
             _netinfo = netinfo.NetInfo()
             hwaddr = (_netinfo.nics[nic.name].get('permhwaddr') or


-- 
To view, visit http://gerrit.ovirt.org/35089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If07817d51ee8c71a1bcfe7d45f110b884fd516fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>


More information about the vdsm-patches mailing list