Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info

phoracek at redhat.com phoracek at redhat.com
Wed Nov 12 13:58:28 UTC 2014


Petr Horáček has posted comments on this change.

Change subject: libnl: make link cache optional for link_info and addr_info
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/32949/9/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:

Line 141:         with _pool.socket() as sock:
Line 142:             if name is None:
Line 143:                 err = _rtnl_link_get_kernel(sock, index, name, byref(link))
Line 144:             else:
Line 145:                 err = _rtnl_link_get_kernel(sock, index, name, byref(link))
the same if and else
Line 146:     else:
Line 147:         err = _rtnl_link_get_kernel(sock, index, name, byref(link))
Line 148:     if err:
Line 149:         raise IOError(-err, _nl_geterror())


-- 
To view, visit http://gerrit.ovirt.org/32949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list