Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

asegurap at redhat.com asegurap at redhat.com
Tue Nov 11 17:59:05 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema: Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

Sorry I forgot about this little detail.

http://gerrit.ovirt.org/#/c/32915/6/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2356:             create_bond_with_mode(nics, 1)
Line 2357:             self.assert_active_slave_exists(BONDING_NAME, nics)
Line 2358:             create_bond_with_mode(nics, 4)
Line 2359:             self.assert_active_slave_doesnt_exist(BONDING_NAME)
Line 2360
You should be destroying the bond after this:
    status, msg = self.vdsm_net.setupNetworks({}, {BONDING_NAME: {'remove': True}}, NOCHK)
    self.assertEqual(status, SUCCESS, msg)


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list