Change in vdsm[master]: netlink: event monitor

asegurap at redhat.com asegurap at redhat.com
Tue Nov 11 17:33:41 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netlink: event monitor
......................................................................


Patch Set 29: Code-Review-1

(1 comment)

I made this comment expecting the context manager to need it.

http://gerrit.ovirt.org/#/c/32626/29/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:

Line 79:             while True:
Line 80:                 if self._thread.is_alive():
Line 81:                     value = self._thread._queue.get()
Line 82:                     if value == _STOP_QUEUE:
Line 83:                         raise StopIteration
This will only happen when there is a timeout, right? If that is the case, we should be raising something else like TimeoutError?
Line 84:                     yield value
Line 85:                 else:
Line 86:                     value = self._thread._queue.get_nowait()
Line 87:                     if value != _STOP_QUEUE:


-- 
To view, visit http://gerrit.ovirt.org/32626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list