Change in vdsm[master]: virt: migration: decouple monitoring from thread

asegurap at redhat.com asegurap at redhat.com
Wed May 21 11:23:14 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: virt: migration: decouple monitoring from thread
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26279/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 474:             downtime = self.update_downtime(self._downtimeStep)
Line 475:             self._vm.log.debug('setting migration downtime to %d', downtime)
Line 476:             self._vm._dom.migrateSetMaxDowntime(downtime, 0)
Line 477:             self._downtimeStep += 1
Line 478:         return False
if monitor_downtime always returns False, 'done' at line 363 will always be false.


-- 
To view, visit http://gerrit.ovirt.org/26279
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list