Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

fromani at redhat.com fromani at redhat.com
Wed May 21 11:20:46 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: Add force and timeout options to VM.shutdown
......................................................................


Patch Set 6:

(2 comments)

I'm OK with the code. I just have a couple of questions, not enough for a  -1.

http://gerrit.ovirt.org/#/c/27054/6//COMMIT_MSG
Commit Message:

Line 13: alternative method of shutdown/reboot.
Line 14: 
Line 15: If 'force' is True and all graceful methods fail, we reset/destroy the VM.
Line 16: 
Line 17: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054070
Sorry, I'm having quite an hard time to see how this change helps with
"Let VDSM detect reboots of the vm and add the possibility to detach run-once isos", could you please add a couple of lines to help me understand? A reply to this note is 100% fine.
Line 18: Change-Id: I30180f9906eb45fa485aa7d773a436e62bd3c815


http://gerrit.ovirt.org/#/c/27054/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 130: 
Line 131:         ('max_outgoing_migrations', '3',
Line 132:             'Maximum concurrent outgoing migrations'),
Line 133: 
Line 134:         ('sys_shutdown_timeout', '120',
No objections, but care to explain why this is needed?
Again, for documentation mostly
Line 135:             'Destroy and shutdown timeouts (in sec) before completing the '
Line 136:             'action.'),
Line 137: 
Line 138:         ('user_shutdown_timeout', '30',


-- 
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30180f9906eb45fa485aa7d773a436e62bd3c815
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list