Change in vdsm[master]: keep pauseCode when migrating paused VM

ahadas at redhat.com ahadas at redhat.com
Mon May 19 08:23:01 UTC 2014


Arik Hadas has posted comments on this change.

Change subject: keep pauseCode when migrating paused VM
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1957:             if migrating and self.lastStatus != vmstatus.DOWN:
Line 1958:                 self._waitForIncomingMigrationFinish()
Line 1959: 
Line 1960:             self.lastStatus = vmstatus.UP
Line 1961:             if self._initTimePauseCode:
> I think the current code is broken.
but as long as 
  self._initTimePauseCode = self._readPauseCode(0)
is executed, we won't clear the pause-code (#1961)
so as long as pause code = NOERR + status != paused is ok, it should be fine, right?

I wonder why don't we call _readPauseCode only when the status is paused..
Line 1962:                 self.conf['pauseCode'] = self._initTimePauseCode
Line 1963:                 if self._initTimePauseCode == 'ENOSPC':
Line 1964:                     self.cont()
Line 1965:             elif not migrating:


-- 
To view, visit http://gerrit.ovirt.org/27801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list