Change in vdsm[master]: json-rpc: Protocol detection

smizrahi at redhat.com smizrahi at redhat.com
Sun May 18 13:29:10 UTC 2014


Saggi Mizrahi has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 14:

(1 comment)

Just adding info on last review.
Starting to review latest version now.

http://gerrit.ovirt.org/#/c/26300/14/vdsm/protoDetector.py
File vdsm/protoDetector.py:

Line 177:     def __init__(self, xmlBinding):
Line 178:         self.xmlBinding = xmlBinding
Line 179: 
Line 180:     def detect(self, data):
Line 181:         return data.startswith("POST") or data.startswith("PUT")
> We have a patch adding GET for getting images data, so this should be updat
Just add detection for all HTTP commands and add pass it to an HTTP router that is responsible for passing the request based on path and command.
Line 182: 
Line 183:     def handleSocket(self, client_socket, socket_address):
Line 184:         self.xmlBinding.add_socket(client_socket, socket_address)
Line 185:         self.log.debug("xml over http detected from %s", socket_address)


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list