Change in vdsm[master]: hooks: Add hook for fake VM stats

dkuznets at redhat.com dkuznets at redhat.com
Tue May 13 06:43:58 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: hooks: Add hook for fake VM stats
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.ovirt.org/#/c/25927/17/vdsm/vdsmd.8.in
File vdsm/vdsmd.8.in:

Line 67: in lexicographic order.
Line 68: 
Line 69: .SS Hook environment
Line 70: Each hook script (except before_vdsm_start, after_vdsm_stop, 
Line 71: before_network_setup and after_network_setup, before_get_vm_stats, 
> Do we need spaces at the end of line here and in line 139?
Done
Line 72: after_get_vm_stats, before_get_all_vm_stats, after_get_all_vm_stats)) inherit 
Line 73: the environment of the VDSM process, with an additional variable
Line 74: .B _hook_domxml
Line 75: which holds the path of libvirt's


-- 
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list