Change in vdsm[master]: Allow moving of sparse images to a block domains

amureini at redhat.com amureini at redhat.com
Sun Mar 30 11:28:59 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: Allow moving of sparse images to a block domains
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

This patch is not about canDoAction - the bug is about moving a sparse disk from file to block domain.

First thing it should be supported by the underlying layer, and when that's done, the validation should be removed.

http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 357:                     # To avoid prezeroing preallocated volumes on NFS domains
Line 358:                     # we create the target as a sparse volume (since it will be
Line 359:                     # soon filled with the data coming from the copy) and then
Line 360:                     # we change its metadata back to the original value.
Line 361:                     if destDom.supportsSparseness:
> This logic should be moved to  .*Volume._create() functions, simplifiying t
I agree about moving the logic, but I don't think it should block /this/ patch - this code has been here for a while. Let's get it to WORK, and then we can discuss how it should be refactored.
Line 362:                         tmpVolPreallocation = volume.SPARSE_VOL
Line 363:                     else:
Line 364:                         tmpVolPreallocation = volume.PREALLOCATED_VOL
Line 365: 


-- 
To view, visit http://gerrit.ovirt.org/25778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list