Change in vdsm[master]: Allow moving of sparse images to a block domains
ewarszaw at redhat.com
ewarszaw at redhat.com
Thu Mar 27 21:15:55 UTC 2014
Eduardo has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
......................................................................
Patch Set 8: Code-Review-1
(2 comments)
How this patch solves the canDoAction engine warning logged in the BZ?
http://gerrit.ovirt.org/#/c/25778/8//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-03-24 19:21:30 +0200
Line 4: Commit: Tal Nisan <tnisan at redhat.com>
Line 5: CommitDate: 2014-03-25 18:10:15 +0200
Line 6:
Line 7: Allow moving of sparse images to a block domains
Should be noted that this is valid for copy operations too.
Line 8:
Line 9: When attempting to move a sparse image from a file domain to a block domain
Line 10: the destination image is created as sparse which is not supported on block
Line 11: domains.
http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py
File vdsm/storage/image.py:
Line 357: # To avoid prezeroing preallocated volumes on NFS domains
Line 358: # we create the target as a sparse volume (since it will be
Line 359: # soon filled with the data coming from the copy) and then
Line 360: # we change its metadata back to the original value.
Line 361: if destDom.supportsSparseness:
This logic should be moved to .*Volume._create() functions, simplifiying the logic and restore here and removing SD.createVolume() driver function.
Additionally the misuse of "sparse" parameter for block volumes instead of "thin" can be clarified.
Line 362: tmpVolPreallocation = volume.SPARSE_VOL
Line 363: else:
Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL
Line 365:
--
To view, visit http://gerrit.ovirt.org/25778
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list