Change in vdsm[master]: VmStatsThread: make _getNicStats testable

danken at redhat.com danken at redhat.com
Fri Mar 28 14:46:24 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: VmStatsThread: make _getNicStats testable
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 622
Line 623
Line 624
Line 625
Line 626
> Swallowing those exceptions is not required anymore?
Indeed! It was quite evil to begin with. TypeError was caused when there's only one sample, and start_sample = end_sample = None. That's avoided by the new

  if sInfo is None:
    return

ZeroDivisionError is from the ages before ifSpeed was calculated in-function.

And KeyError? I think you've got me here. My suggested code may explode on hot-plug.


-- 
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list