Change in vdsm[master]: VmStatsThread: make _getNicStats testable

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Mar 28 14:37:34 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: VmStatsThread: make _getNicStats testable
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 590:             self._log.debug("CPU stats not available: %s", e)
Line 591:             stats['cpuUser'] = 0.0
Line 592:             stats['cpuSys'] = 0.0
Line 593: 
Line 594:     def _getNicStats(self, name, model, mac,
@staticmethod?
Line 595:                      start_sample, end_sample, interval):
Line 596:         ifSpeed = [100, 1000][model in ('e1000', 'virtio')]
Line 597: 
Line 598:         ifStats = {'macAddr': mac,


-- 
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list