Change in vdsm[master]: Introduction for caching the parsed domain XML

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 24 12:56:48 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Introduction for caching the parsed domain XML
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:

Line 4634:             pass
Line 4635:         return pid
Line 4636: 
Line 4637:     def _getUnderlyingVmInfo(self):
Line 4638:         self._lastXMLDesc = ParsedDomXML(self._dom.XMLDesc(0))
> The return value was never used anywhere, that's why I dropped it. It's not
Obviously libvirt API is not clear, and we would like to have more clear code, so it is easy to work with. Of course this should be handled in another patch.
Line 4639: 
Line 4640:     def _ejectFloppy(self):
Line 4641:         if 'volatileFloppy' in self.conf:
Line 4642:             utils.rmFile(self.conf['floppy'])


-- 
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list